fix(admin-ui): rename "Authn" to "Authentication" in menu and page title #2304#2397
fix(admin-ui): rename "Authn" to "Authentication" in menu and page title #2304#2397
Conversation
…i-issue-2250-clean
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughRename public translation keys from Changes
Sequence Diagram(s)sequenceDiagram
participant C as Component
participant I as i18n (translation.json)
participant T as SetTitle (UI header)
Note over C,I: On component mount
C->>I: t('titles.authentication')
I-->>C: "Authentication" (localized)
C->>T: SetTitle("Authentication")
T-->>C: Title updated (UI)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (2)
Comment |
mo-auto
added
comp-admin-ui
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (8)
admin-ui/app/locales/en/translation.json(2 hunks)admin-ui/app/locales/es/translation.json(2 hunks)admin-ui/app/locales/fr/translation.json(2 hunks)admin-ui/app/locales/pt/translation.json(2 hunks)admin-ui/plugins/auth-server/components/Agama/AgamaAliasListPage.js(2 hunks)admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js(1 hunks)admin-ui/plugins/auth-server/components/AuthN/AuthNListPage.js(1 hunks)admin-ui/plugins/auth-server/plugin-metadata.js(1 hunks)
🔇 Additional comments (10)
admin-ui/app/locales/es/translation.json (2)
644-646: Sidebar label updated correctlymenus.authentication → "Autenticación" aligns with PR objective.
938-940: Page title key updated correctlytitles.authentication → "Autenticación" is consistent with components.
admin-ui/app/locales/pt/translation.json (1)
43-45: Sidebar label addedmenus.authentication → "Autenticação" looks good.
admin-ui/app/locales/en/translation.json (1)
644-646: Menu key migrated to authenticationmenus.authentication → "Authentication" matches plugin metadata and UI usage.
admin-ui/app/locales/fr/translation.json (2)
43-43: LGTM! French menu translation added correctly.The addition of "authentication": "Authentification" to the menus section correctly translates the new menu label to French and aligns with the PR's objective to rename "Authn" to "Authentication".
905-905: LGTM! French page title translation added correctly.The addition of "authentication": "Authentification" to the titles section correctly translates the new page title to French and aligns with the PR's objective.
admin-ui/plugins/auth-server/components/Agama/AgamaListPage.js (1)
228-228: LGTM! Page title updated to use new translation key.The page title correctly uses the new
titles.authenticationtranslation key, ensuring consistency across the Admin UI as per the PR objective.admin-ui/plugins/auth-server/components/AuthN/AuthNListPage.js (1)
47-47: LGTM! Page title updated to use new translation key.The page title correctly uses the new
titles.authenticationtranslation key, maintaining consistency with the broader renaming effort across the Admin UI.admin-ui/plugins/auth-server/components/Agama/AgamaAliasListPage.js (1)
21-21: LGTM! Page title functionality added correctly.The import of
SetTitleand its usage withtitles.authenticationproperly sets the page title for the Aliases page, maintaining consistency with the other authentication-related pages in the Admin UI.Also applies to: 48-48
admin-ui/plugins/auth-server/plugin-metadata.js (1)
116-116: LGTM! Menu title translation key updated correctly.The menu title has been correctly updated from
menus.authntomenus.authentication, which will display "Authentication" instead of "Authn" in the sidebar navigation. The path and permission remain unchanged, which is appropriate since this is purely a labeling change.
|
4 participants
fix(admin-ui): rename "Authn" to "Authentication" in menu and page title #2304
Description
This PR updates the label and title “Authn” within the Admin UI sidebar to “Authentication” for improved clarity and user experience. The change ensures consistency across the sidebar menu and page headers.
Summary
Expected Behavior
Both the sidebar and page title should now display Authentication instead of Authn.
🔗 Ticket
Closes: #2304
Summary by CodeRabbit
Updates
Localization